Bug report: champion skill points in CSBuild

Discuss Chaos Strikes Back for Windows and Linux, an unofficial port of Chaos Strikes Back to PC by Paul Stevens, as well as CSBuild, an associated dungeon editor.

Moderator: Zyx

Forum rules
Please read the Forum rules and policies before posting.
Post Reply
User avatar
ChristopheF
Encyclopedist
Posts: 1259
Joined: 24-Oct-99 12:36
Location: France
Contact:

Bug report: champion skill points in CSBuild

Post by ChristopheF » 14-Jan-11 19:36

I think there is a bug in CSbuild: when you edit a text item defining a champion in the Hall of Champions, you can click the "Edit Portrait" button to see the skill points in "associated skills":
Image
The drop down lists contain 18 values 0, 250, 500, 1000, 2000, 4000, etc...
However, I believe value 250 should be removed from this list. The shown values are thus incorrect. For example on the screenshot above, the values should be 1000, 1000, 500, 1000.

I have confirmed this by checking the values in the original MINI.DAT from CSB for Atari ST (the Halk Gonzo Barbarian champion) and compared with the skill levels displayed in-game. They do correspond to the table available here: http://dmweb.free.fr/?q=node/691#toc8

Moreover, in the CSBwin source code, the "DetermineMastery" function does use "500" as the basic skill level unit, not 250.

Note that the same bug is present in DMute.

User avatar
Zyx
DSA Master
Posts: 2564
Joined: 5-Jun-00 11:53
Location: in the mind
Contact:

Re: Bug report: champion skill points in CSBuild

Post by Zyx » 15-Jan-11 01:45

It's not a bug, it's a feature! A starting character with 250 experience points will reach neophyte sooner, and that is noticeable in the first minutes of play. Of course, one should be able to enter any value, but 250 was quite handy, at least for me.

User avatar
ChristopheF
Encyclopedist
Posts: 1259
Joined: 24-Oct-99 12:36
Location: France
Contact:

Re: Bug report: champion skill points in CSBuild

Post by ChristopheF » 15-Jan-11 08:36

The problem is that the champion text string does not contain a number of experience points (in which case you could specify any value) but it contains the initial skill level (values between 0 and 15 only). You can check in the dungeon.dat specs: http://dmweb.free.fr/?q=node/217#toc31 .
The bug is only a display bug in CSBuild: If you select the Nth entry in the list, the skill level will be set to N. The first entry (index = 0) is skill level 0 ==> 0 XP. The second entry is indeed skill level = 1, but the real corresponding amount of XP is not 250, it is 500. I think it would be clearer if the list showed the skill level names and numbers instead of the corresponding XP points, as this would show what is really stored in the string and not an interpreted value of XP point that makes users think they should be allowed to enter any XP value.

User avatar
Paul Stevens
CSBwin Guru
Posts: 4099
Joined: 8-Apr-01 16:00
Location: Madison, Wisconsin, USA

Re: Bug report: champion skill points in CSBuild

Post by Paul Stevens » 15-Jan-11 16:21

Skill level names and numbers?

0 aaaaa
1 bbbbb
2 ccccc
.....

What should the entries be?

User avatar
ChristopheF
Encyclopedist
Posts: 1259
Joined: 24-Oct-99 12:36
Location: France
Contact:

Re: Bug report: champion skill points in CSBuild

Post by ChristopheF » 15-Jan-11 20:03

The skill level names and numbers can be found here: http://dmweb.free.fr/?q=node/691#toc8

User avatar
Paul Stevens
CSBwin Guru
Posts: 4099
Joined: 8-Apr-01 16:00
Location: Madison, Wisconsin, USA

Re: Bug report: champion skill points in CSBuild

Post by Paul Stevens » 15-Jan-11 20:53


User avatar
ChristopheF
Encyclopedist
Posts: 1259
Joined: 24-Oct-99 12:36
Location: France
Contact:

Re: Bug report: champion skill points in CSBuild

Post by ChristopheF » 15-Jan-11 22:35

Many thanks for your quick feedback and fix. Great support as usual!

Post Reply