Page 1 of 1
(fixed in 0.79) [0.78] Multiple protections display broken
Posted: Thu Apr 08, 2021 1:27 pm
by kaypy
In older versions, casting eg ya-ir and ful-bro-neta would get you an outline with a mix of blue and green dashes.
In 0.78, you only get one type of protection showing. I believe both are still active (and if one times out, the other will be shown), but you can no longer tell by the display.
Hmm. I should go back and try to figure out exactly when things broke.
...
0.72 also has the bad display
0.71 is ok
Re: [0.78] Multiple protections display broken
Posted: Thu Apr 08, 2021 1:45 pm
by kaypy
Conditions.lua had a big overhaul of the conditions table setup from 0.71 to 0.72. I assume the corresponding c code changed extensively too.
Re: [0.78] Multiple protections display broken
Posted: Thu Apr 08, 2021 11:18 pm
by Sophia
They're both still being drawn. The problem is the order is no longer defined, and it seems to draw Ya-Ir on top, which completely obscures Ful-Bro-Neta. I'll specify the draw order in 0.79.
(By the way, the underlying C code hardly changed at all. The table stuff is all implemented in Lua, and is really just a much nicer looking frontend for dsb_add_condition, which is still there under the hood)
Re: (fixed in 0.79) [0.78] Multiple protections display broken
Posted: Fri Apr 09, 2021 2:14 am
by kaypy
Thanks.
And with that knowledge, I hacked in a temporary blueshield image that doesn't cover the same pixels as the fireshield 8-)
But that leads me to another question: At what point are conditions actually set? I had to hack the base gfx. Tweaking the conditions table in my code didn't seem to do anything...
Re: (fixed in 0.79) [0.78] Multiple protections display broken
Posted: Fri Apr 09, 2021 11:56 am
by Gambit37
In my DM update I've redesigned those graphics so that they don't obscure each other, so I'd never noticed the issue!