Pits look weird - need repositioning

[Gambit37]

The position of pits on the floor and ceiling is wrong.

This has bugged me for years, but I couldn't quite put my finger on exactly what it was. Playing the first part of Surgical Strike just now, it was easy to see that many ceiling pits don't line up with their floor counterparts.

I decided to do a compare between CSBWin and RTC to see exactly the difference. I was very surprised. Not only are the pits out in several places in RTC, the graphics are very different.

Firsat, RTC's floor pits don't have the lip around the edge. The very central front pit has far corners that don't line up with the verticals.

Second, in terms of position, the worst offenders are the first row ceiling pits, left and right -- they are too far off the screen and need to come towards the center by 28 pixels. The angle of the edges of the second row centre floor pit is wrong. The right and left centre floor pits in rows 1 and 2 are too close to the middle -- they need to go further off screen. There are other minor discrepancies.

Have a look at this anim to see what I mean. You'll see the spacing between pits in CSBWin is consistent and perspectively correct. RTC isn't.



I'm curious to know which version of the game you got the pit graphics from George? Would it possible for you to modify the positions to more closely match the original game, and to put back the 'lipped' floor pits? I can provide them if you like.

EDIT:

I checked my archives and see that your images come from the PC version of DM. Another small difference is that the floor fades sooner in CSBWin and in conjunction with the better pit graphics, makes for a more pleasing effect. I guess FTL took the opportunity to clean this stuff up in CSB. It would be nice for RTC to also look as good as possible.

[George Gilbert]

Yes that is interesting - as you say, it looks like the graphics did change for CSB. Strangely though, wasn't PC DM released after CSB which would mean that they reverted back to the old graphics set?

Anyway, I agree that the graphics look better in CSB and the pit alignment should certainly be sorted out. Any chance you could send me the ripped bitmaps? If you could send me the offsets required too it would be extremely helpful.

[Gambit37]

No problem -- can you remined me exactly how the coordinates work in RTC so I can give you the correct values, rather than just saying 2move this pit 16 pixels right". I can't remember if they work from the centre of a bitmap or top left, and where the relative positioning in the viewport starts.

Also, do you want the revised floor and ceiling?

[George Gilbert]

No problem -- can you remined me exactly how the coordinates work in RTC so I can give you the correct values, rather than just saying 2move this pit 16 pixels right". I can't remember if they work from the centre of a bitmap or top left, and where the relative positioning in the viewport starts.

Not quite as easy as that - the coordinates are relative offsets to the tile centers. The best bet is to start off with the values used by the existing pits (which you can get from the editor), compile them into a dungeon, take a screenshot and then adjust them so that the output matches what you want...

Also, do you want the revised floor and ceiling?

If it's easy to do...

[Gambit37]

Easy to do: If I use an image of the correct pits from CSBWin as the background image for the whole interface, it shows up when sleeping... easy then to compare positions by toggling between the dungeon and sleeping!

Not sure when I can do this, but it will be this week.

[linflas]

talking about offsets, i need some info for my tool : when grabbing image from 3d, it while save it as a bmp -and- put the offset values in a txt file.
so i really need to know how the whole offset thing works in RTC, even if it's not that easy

[George Gilbert]

I've just re-checked this, and (although I completely agree that the pit perspective looks wrong), it's actually identical to DM.

Doing the same style of screen shot as above, the DM and RTC images of a room full of pits are exactly the same.

[Gambit37]

Yes, but the point being that it was never right in DM which is why FTL cleaned it up in CSB.

If you still want the new CSB pits, let me know as I'm part way through it.

[George Gilbert]

No that's alright - I've got the new pit graphics (and have actually nearly finished integrating them!)

Interestingly, despite the differences in perspective between the CSB and DM engines, the pit positions aren't that different...it seems that the major difference is just in what walls are drawn and where - the floors stay the same.

[George Gilbert]

Now done for V0.35