DM & CSB review of possible bugs and missing stuff

[Joramun]

All those bugs are either translation issues or missing stuff in DSB :
DM :
- DSB doesn't use WALLITEM_ACTION, so there is a single place in DM where it might crash : the Fountain that accepts one wish. It's early, but I think I tested it and it was ok.
- No END_GAME_PAD...

CSB :
- No INTRO
- No "make new adventure" feature (replaced by button + teleporter in the prison)
- No creature "lord grey" [I could modify the game in order to play the DM ending on the FUL YA pit, though]
- No Endgame pad ...

[Remy]

DSB doesn't use WALLITEM_ACTION, so there is a single place in DM where it might crash :

I decided to see if this worked in the version of your DM dungeon I had (I can't recall when I downloaded it - not that long ago, but the ReadMe refers to DSB 0.14).
It works, but only partway. The coin remains in your hand. I found the fountain in the code (RTC_1703a), and it's missing an Exvar.

Code: Select all

Line 4237: exvar[RTC_1703a]={target={RTC_1703b,RTC_1703c},delay=1,opby="coin_copper",disable_self=true,msg=M_ACTIVATE}

Should have a 'destroy = true' exvar in there. Technically, in DSB you wouldn't even need the x_relay (RTC_1703b) you're using right now. Instead, everything could be handled by the fountain.

Code: Select all

exvar[RTC_1703a]={
target=RTC_1706,
delay=1,
opby="coin_copper",
disable_self=true,
destroy=true,
msg=M_DEACTIVATE }

RTC_1703b and RTC_1703c aren't needed anymore (actually, I'm not sure what RTC_1703c does - it's gets spawned, but I don't see where it ever shows up again).

[Joramun]

You're right about that fountain, I checked it long ago, but I was just too Luazy to correct it, since every time I updated RTSB, I also updated DM and CSB from their RTC versions... I already had to tweak the RTC dungeon to get some things clean in DSB soooooo I just didn't correct the fountain each (any) time...

RTSB is just a text parser/ text spitter, so basically it just reads and write a dungeon as a list of character patterns, there is only the strict minimum of logical treatment in it. (Like putting the exvars at the end etc.)

Obviously, interpreting RTC things like WALLITEM_ACTION for a converter would be SUPRA-UBER-TECHNOPANZER difficult. (ask Trantor, it means very difficult)

Now it's late, and I'll get spanked by myself tomorrow if I don't go to sleep.

I promise, I will correct DM and CSB and release a final version of them, ONE DAY.

EDIT: Bah, I didn't sleep enough... (slaps himself)

As for RTC_1703c, it doesn't get spawned, but thankfully Sophia was careful and messages passed to "nil" instances just end into void, it doesn't crash the game

And actually, RTSB does a lot more logical treatment than initially expected...
Like putting items worn by monster into their inventory, rather that the literal RTC translation
[ i.e. spawn into LIMBO, then attach to inventory... (well, that's how I interpret the coordinates of contained items in RTC) ]