(fixed) Pit damage Bug

[Sophia]

Downloaded dsbtest33.zip and the
CSB port.

Got fatal LUA ERROR

Lua function pit.on_trigger: base/triggers.lua;480 attempt to perform arithmetic on global 'damage_amount' (a nil value)

Happened only 30 seconds into the game after running
away from the opening worms.

Line 480 of base/triggers.lua looks something like:

Code: Select all

dsb_set_hp(what, dsb_get_hp(what) - damage_amount)

This bug can be fixed for the time being by adding

Code: Select all

local damage_amount = 20

just above the previous line. That will cause damage_amount to be defined and the game won't error out any more.

I'll have a better fix in DSB 0.34.

[Joramun]

Hey, cool, someone is actually testing my conversions !

(I expect them to be bug-ridden,
especially the endgame mechanics !!)

[Paul Stevens]

Hey, cool, someone is actually testing my conversions

OK. So it ain't been tested. So I
figures "What the Hell; I'll give it a whirl".
Got another solid 30 seconds of gametime
under my belt. Went upstairs and met
a mummy. Threw something at them.
This ain't exactly the end-game.
Guess I better save more often


Lua function sys_base_impact:base/system.lua:60
attempt to call global monster_took_damage (nil)

[Joramun]

Erm, the mummy probably tried to play base-ball with you.

[Sophia]

None of this is Joramun's or CSB's fault.

It actually has to do with the new "hook" system, and not testing that enough.

I renamed/moved around a bunch of functions and apparently forgot a couple.

[Joramun]

OK. So it ain't been tested.

Actually, I test almost everything EXCEPT the endgame mechanics of CSB. The DM one is ok.

[ian_scho]

It actually has to do with the new "hook" system, and not testing that enough.

I renamed/moved around a bunch of functions and apparently forgot a couple.

Hi. Was function monster_took_damage(...) one of them? You need someone to write you some unit tests